Skip to content

Conversation

rdmarsh2
Copy link
Contributor

In preparation for a C++ autobuilder on Windows, this makes the C# autobuilder use LGTM_PROJECT_LANGUAGE to decide which CodeQL environment variables to read. In particular, it will now use CODEQL_EXTRACTOR_CPP_* when in C++ mode.

rdmarsh2 added 3 commits June 23, 2020 14:47
Left this out earlier because I thought it needed to point to the C#
extractor root even in C++ mode, but it looks like it isn't yet used in
C++ mode.
@rdmarsh2 rdmarsh2 added the C# label Jun 23, 2020
@rdmarsh2 rdmarsh2 requested a review from a team June 23, 2020 22:56
@shtat00
Copy link

shtat00 commented Jun 24, 2020

In preparation for a C++ autobuilder on Windows, this makes the C# autobuilder use LGTM_PROJECT_LANGUAGE to decide which CodeQL environment variables to read. In particular, it will now use CODEQL_EXTRACTOR_CPP_* when in C++ mode.

Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rdmarsh2 rdmarsh2 merged commit 38067b5 into github:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants