C#: Move async data-flow tests from local to global #3798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calumgrant
suggested changes
Jun 26, 2020
| public async void M3() | ||
| { | ||
| // async await, tainted | ||
| var sink41 = Task.Run(() => "taint source"); |
| // async await, tainted | ||
| var sink41 = Task.Run(() => "taint source"); | ||
| Check(sink41); | ||
| var sink42 = await sink41; |
There was a problem hiding this comment.
sink0 and sink1 are already used in another test, so that's why I went for the next available numbers.
calumgrant
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests rely on flow out of callables, and are therefore inter-procedural.