JS: teach the dataflow library identity functions Object.freeze/seal #3805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esbena
added
JS
Awaiting evaluation
esbena
force-pushed
the
js/seal-freeze-flow
branch
from
265c33b to
91c1663
Compare
asgerf
reviewed
Jun 25, 2020
| /** | ||
| * Gets an identity call for `input` that can be recognized syntactically. | ||
| */ | ||
| DataFlow::CallNode syntactic(DataFlow::Node input) { |
There was a problem hiding this comment.
The naming is a little weird. From the call site it's not really clear what predicate does.
How about FlowSteps::identityFunctionStep(pred, succ) instead?
esbena
removed
the
Awaiting evaluation
esbena
force-pushed
the
js/seal-freeze-flow
branch
from
91c1663 to
3ca6031
Compare
|
The suggested renaming has been done. |
asgerf
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/github/codeql-javascript-team/issues/195