Skip to content

C++: add MemberFunction::getTypeOfThis() #3814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 30, 2020
Merged

C++: add MemberFunction::getTypeOfThis() #3814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d1d7fac
C++: add member_function_this_type to dbscheme
nickrolfe Jun 10, 2020
133838d
C++: update tests to expect type of `this`
nickrolfe Jun 10, 2020
3b15d39
C++: update stats for new member_function_this_type table
nickrolfe Jun 25, 2020
ca25971
C++: upgrade script for member_function_this_type
nickrolfe Jun 25, 2020
8bd3be6
C++: add MemberFunction::getTypeOfThis()
nickrolfe Jun 25, 2020
9e9d692
C++: add test for MemberFunction::getTypeOfThis()
nickrolfe Jun 25, 2020
e79625e
Accept suggested qldoc change
nickrolfe Jun 26, 2020
309a8e6
C++: add more test cases for the type of `this`
nickrolfe Jun 26, 2020
0ae5fb0
C++: auto-format test query
nickrolfe Jun 26, 2020
ab1dc64
C++: expand qldoc on MemberFunction::getTypeOfThis()
nickrolfe Jun 29, 2020
4b6908c
C++: test template classes with MemberFunction::getTypeOfThis()
nickrolfe Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cpp/ql/src/semmle/code/cpp/MemberFunction.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,14 @@ class MemberFunction extends Function {
result = getADeclarationEntry() and result != getDefinition()
)
}

/**
* Gets the type of the `this` parameter associated with this member function, if any. Typically,
* this will be a `PointerType`, possibly with `const` and/or `volatile` qualifiers.
*/
Type getTypeOfThis() {
member_function_this_type(underlyingElement(this), unresolveElement(result))
}
}

/**
Expand Down
2 changes: 1 addition & 1 deletion cpp/ql/src/semmlecode.cpp.dbscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ function_deleted(unique int id: @function ref);

function_defaulted(unique int id: @function ref);


member_function_this_type(unique int id: @function ref, int this_type: @type ref);

#keyset[id, type_id]
fun_decls(
Expand Down
Loading