Skip to content

C++: getCanonicalQLClass -> getAPrimaryQlClass #3815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2020
Merged

C++: getCanonicalQLClass -> getAPrimaryQlClass #3815

merged 2 commits into from
Jun 26, 2020

Conversation

jbj
Copy link
Contributor

@jbj jbj commented Jun 26, 2020

As discussed in https://github.com/github/codeql-c-analysis-team/issues/101. The old name is now deprecated.

@jbj
C++: getCanonicalQLClass -> getAPrimaryQlClass
c1b26d7 
Also updated the QLDoc for `getAPrimaryQlClass` to match the Go version.
@jbj jbj added the C++ label Jun 26, 2020
@jbj jbj requested a review from a team as a code owner June 26, 2020 11:22
dbartol
dbartol previously approved these changes Jun 26, 2020
View reviewed changes
Copy link

@dbartol dbartol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I haven't looked through every file, but I assume that your favorite search-and-replace tool is working properly.

@jbj
Copy link
Contributor Author

jbj commented Jun 26, 2020

I haven't looked through every file, but I assume that your favorite search-and-replace tool is working properly.

The replacement was done with the only tool I trust (in zsh):

perl -p -i -e 's/getCanonicalQLClass/getAPrimaryQlClass/g' cpp/**/*.ql*

@jbj
Copy link
Contributor Author

jbj commented Jun 26, 2020

The tests are passing now.

dbartol
dbartol approved these changes Jun 26, 2020
View reviewed changes
Copy link

@dbartol dbartol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbartol dbartol merged commit e00a8f7 into github:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dbartol dbartol dbartol approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbj @dbartol