Skip to content

Conversation

dellalibera
Copy link
Contributor

Inspired by #3800 and to expand the support of logging calls (it could be useful for example for this #3734), I found fancy-log, that has 1.8M downloads/week and 1400 dependents. It seems worth modelling.
Any feedback is welcome.

@dellalibera dellalibera requested a review from a team as a code owner June 26, 2020 19:41
@erik-krogh
Copy link
Contributor

LGTM 👍

Could you add fancy-log to the list of libraries where support has been improved here: https://github.com/github/codeql/blob/master/change-notes/1.25/analysis-javascript.md#general-improvements

dellalibera and others added 2 commits June 28, 2020 21:58
Co-authored-by: intrigus-lgtm <60750685+intrigus-lgtm@users.noreply.github.com>
@dellalibera
Copy link
Contributor Author

@erik-krogh Yes, sure! I made the change

@asgerf asgerf added the JS label Jun 29, 2020
@semmle-qlci semmle-qlci merged commit da8725a into github:master Jun 29, 2020
@dellalibera dellalibera deleted the js/fancy-log branch July 2, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants