Skip to content

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Jun 29, 2020

Adds support for Vue component implemented as a class decorated with @Component

For example

<template>
    <p v-html="dataA"/>
</template>
<script>
  import Vue from 'vue'
  import Component from 'vue-class-component'

  @Component
  export default class MyComponent extends Vue {
    message: string = 'Hello!'

    get dataA() {
      return 42; // flows to 'dataA`
    }
  }
</script>
<style>
</style>

@asgerf asgerf added JS Awaiting evaluation Do not merge yet, this PR is waiting for an evaluation to finish labels Jun 29, 2020
@asgerf asgerf force-pushed the js/vue-class-component branch from 5c9a51d to 3e616e9 Compare June 29, 2020 14:54
@asgerf asgerf marked this pull request as ready for review June 29, 2020 18:15
@asgerf asgerf requested a review from a team as a code owner June 29, 2020 18:15
@asgerf
Copy link
Contributor Author

asgerf commented Jun 30, 2020

PR was included in this evaluation

@asgerf asgerf removed the Awaiting evaluation Do not merge yet, this PR is waiting for an evaluation to finish label Jun 30, 2020
Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took a while, but I think I understand it all.
And it all looks good to me.

@semmle-qlci semmle-qlci merged commit c850938 into github:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants