Skip to content

Conversation

igfoo
Copy link
Contributor

@igfoo igfoo commented Jul 2, 2020

Generated copy and move constructors may now be marked as constexpr.

https://git.semmle.com/Semmle/code/pull/37234

@igfoo igfoo added C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR labels Jul 2, 2020
@igfoo igfoo requested a review from a team as a code owner July 2, 2020 13:17
Generated copy and move constructors may now be marked as constexpr.
Copy link
Contributor

@matt-gretton-dann matt-gretton-dann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are expected changes as the C++ FE has been fixed to appropriately mark more autogenerated methods as constexpr.

Leaving to Analysis team to approve

@igfoo igfoo merged commit 22666dd into github:master Jul 7, 2020
@igfoo igfoo deleted the is_constexpr branch July 7, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants