Java: Clarify documentation for Location predicate results #3907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-schaefer
pushed a commit
to max-schaefer/codeql-go
that referenced
this pull request
Jul 7, 2020
max-schaefer
pushed a commit
to max-schaefer/codeql-go
that referenced
this pull request
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way numbering is performed and ranges are expressed differs between programming languages and contexts. E.g. often numbering starts at
0and the start of a range is inclusive while the end of a range is exclusive.For the
Locationclass of QL, it appears numbering starts at 1 and start and end of line and column ranges are inclusive.This pull request adds this information to the respective predicate documentations.
Note: Maybe the text "(inclusive)", added by this pull request, is not meaningful enough. Any feedback suggesting a different solution is welcome.