Skip to content

Conversation

tausbn
Copy link
Contributor

@tausbn tausbn commented Jul 7, 2020

#3443 revived. (There were too many merge errors to deal with otherwise.)

Will need subsequent PRs fixing up test failures (due to deprecated
methods moving around), but other than that everything should be
straight-forward.

Will need subsequent PRs fixing up test failures (due to deprecated
methods moving around), but other than that everything should be
straight-forward.
@tausbn tausbn added the Python label Jul 7, 2020
@tausbn tausbn requested a review from a team as a code owner July 7, 2020 13:52
RasmusWL
RasmusWL previously approved these changes Jul 7, 2020
Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over all non whitespace-only changes, and it looks good 👍

Comment on lines -9 to -26

// /**
// * Holds if taint propagates from `source` to `sink` in zero or more local
// * (intra-procedural) steps.
// */
// predicate localTaint(DataFlow::Node source, DataFlow::Node sink) { localTaintStep*(source, sink) }

// // /**
// // * Holds if taint can flow from `e1` to `e2` in zero or more
// // * local (intra-procedural) steps.
// // */
// // predicate localExprTaint(Expr e1, Expr e2) {
// // localTaint(DataFlow::exprNode(e1), DataFlow::exprNode(e2))
// // }

// // /** A member (property or field) that is tainted if its containing object is tainted. */
// // abstract class TaintedMember extends AssignableMember { }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, huh. I guess those empty lines really ought to have had empty comments as well.

@RasmusWL RasmusWL merged commit 1d5ef38 into github:master Jul 7, 2020
@tausbn tausbn deleted the python-qlformat-everything-again branch February 12, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants