Java: Move QueryInjectionSink into importable library
#3926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables defining of new sinks to customise the CWE-089 queries.
aschackmull
requested changes
Jul 9, 2020
There was a problem hiding this comment.
The two classes SqlInjectionSink and PersistenceQueryInjectionSink should also be moved to the new file. This makes the definition of QueryInjectionSink more transparent and ensures that they are always part of QueryInjectionSink even if this is referenced in a different query. The newly added file should also have file-level qldoc (in the style "Provides classes for reasoning about ..." or something that's grammatically similar, i.e. the sentence should start with an assumed implicit "This file module").
aschackmull
reviewed
Jul 9, 2020
Also, when moving these, we should make them |
Join SqlInjectionSink and PersistenceQueryInjectionSink with QueryInjectionSink to make its definition more transparent.
aschackmull
reviewed
Jul 9, 2020
Extends from the more general DataFlow::Node instead of DataFlow::ExprNode
aschackmull
reviewed
Jul 9, 2020
aschackmull
reviewed
Jul 9, 2020
aschackmull
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables defining of new sinks to customise the CWE-089 queries.