SuspiciousCallToMemset: Simplify pointer indirection computation #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavgust
force-pushed
the
fix/suspicious-memset-perf
branch
from
60cd334 to
d5c8ea3
Compare
geoffw0
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On large and template-heavy C++ code bases, we've observed hundreds of thousands of local typedefs targetting the same type. Previously, all pairs of such typedefs would be stored as aliases of each other at indirection level 0 in
pointerIndirection, which proved problematic.This PR instead insists that the
basetype of a pair inpointerIndirectionis fully stripped. In this way, we store a linear rather than quadratic number of facts.@geoffw0, you wanted to have a look at this.