C#: Simpler data-flow modelling of parameters #4557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
csharp/dataflow/parameters
branch
from
27c0975 to
e5b5b17
Compare
hvitved
force-pushed
the
csharp/dataflow/parameters
branch
2 times, most recently
from
7f8b761 to
ead0dc5
Compare
hvitved
force-pushed
the
csharp/dataflow/parameters
branch
from
ead0dc5 to
d4562fe
Compare
tamasvajk
previously approved these changes
Jan 27, 2021
hvitved
force-pushed
the
csharp/dataflow/parameters
branch
from
edc1039 to
e6f81bc
Compare
|
Rebased to resolve merge conflict. |
tamasvajk
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gathers all explicit parameter nodes under a single
TExplicitParameterNodeinjector, as opposed to being split out over (a subset of)TSsaDefinitionNode,TCilParameterNode, andTSummaryParameterNode. Implicit parameter nodes (e.g., implicitthisparameters) are unchanged.https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/789/