Python: Promote experimental queries #4583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DO NOT MERGE Also adds performance fix to `python.qll`.
This was a bit of a mess, since there was crosstalk between the TarSlip and PathInjection queries. (Also one of these needs the `options` file to be in one way, and the other not). To fix this, I split these out into separate directories.
RasmusWL
reviewed
Nov 2, 2020
| @@ -0,0 +1 @@ | |||
| semmle-extractor-options: --max-import-depth=2 -p ../lib | |||
There was a problem hiding this comment.
I think the tests will fail due to ../lib not being resolved in the same way as it used to.
For our purposes, I would be happy to accept not having any tests of the old queries. It might be controversial, but that is how I feel about it right now 😄
There was a problem hiding this comment.
Hah, I was anticipating the opposite, hence the inclusion of the tests.
Anyway, at least this is better than my first attempt, which only included the tests! 🤦
RasmusWL
previously approved these changes
Nov 2, 2020
yoff
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGEAlso adds performance fix to
python.qll.