Skip to content

JS: Make ReDoS.ql understand lots of character classes #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Nov 24, 2020
Merged

JS: Make ReDoS.ql understand lots of character classes #4585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d04f3df
remove rendundant check
erik-krogh Oct 31, 2020
321cf09
add redos support for the simplest possible inverted char class
erik-krogh Oct 31, 2020
64d680e
support that an inverted char class can intersect with itself
erik-krogh Oct 31, 2020
804aaf3
support inverted char class and dot
erik-krogh Oct 31, 2020
16473fc
matching a inverted char class with a char
erik-krogh Oct 31, 2020
82252c0
detect redos between charclass and inverted charclass
erik-krogh Nov 2, 2020
4ede04f
improve performance by pruning based on shared root
erik-krogh Nov 2, 2020
a09ffd5
expand `getAOverlapBetweenCharacterClasses` to support overlap betwee…
erik-krogh Nov 1, 2020
fa54ad1
refactor character class implementation in ReDoS.ql - preparing suppo…
erik-krogh Nov 1, 2020
68fe030
support \d \s and \w in ReDoS.ql
erik-krogh Nov 1, 2020
2dd8b6f
support \f and \v in the \s class
erik-krogh Nov 2, 2020
0063cb1
add support for \W, \S, \D
erik-krogh Nov 2, 2020
a5e75f5
add support for escape char classes inside char classes
erik-krogh Nov 2, 2020
d038e9c
small performance improvements
erik-krogh Nov 2, 2020
5f199e8
improve performance by removing bindingset[char]
erik-krogh Nov 3, 2020
ac514b1
remove false positives where the analysis would wrongly conclude that…
erik-krogh Nov 4, 2020
34fd0d8
finding the minimum that is not an FP - instead of finding the minimu…
erik-krogh Nov 4, 2020
17a687b
testing many possible intersections, instead of a single intersection
erik-krogh Nov 5, 2020
3ef5d89
update expected output
erik-krogh Nov 2, 2020
2f4fcc2
Apply suggestions from code review
erik-krogh Nov 13, 2020
affb11b
changes based on review
erik-krogh Nov 13, 2020
a49b99b
autoformat
erik-krogh Nov 13, 2020
97acf1f
fix FP related to inverted character classes choosing a char that was…
erik-krogh Nov 17, 2020
c4d7533
Merge branch 'main' into moreReDoS
erik-krogh Nov 17, 2020
55f2f86
limit the search of state-pairs to the ones that are reachable within…
erik-krogh Nov 17, 2020
8270bf5
make the character search skip unencodable characters
erik-krogh Nov 18, 2020
c4153a6
remove duplicated test cases from ReDoS, and adjust variables names t…
erik-krogh Nov 18, 2020
58c31f0
prune more regexps initially in the ReDoS query
erik-krogh Nov 18, 2020
cc1d797
adjust top comment to reflect what the query does, and add comment ab…
erik-krogh Nov 18, 2020
a3b21ad
Apply suggestions from code review
erik-krogh Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading