Skip to content

JS: Don't compute big string concatenations in Expr.qll #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2020
Merged

JS: Don't compute big string concatenations in Expr.qll #4624

merged 1 commit into from
Nov 6, 2020

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Nov 5, 2020 •
edited
Loading

Doing an inline cast was not my first choice, but I had to do something where it would join on SmallConcatRoot before doing the strictconcat.

@erik-krogh erik-krogh requested a review from a team as a code owner November 5, 2020 21:56
@github-actions github-actions bot added the JS label Nov 5, 2020
asgerf
asgerf reviewed Nov 5, 2020
View reviewed changes
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! We should probably do an evaluation, though.

@erik-krogh
Copy link
Contributor Author

Great! We should probably do an evaluation, though.

Evaluation looks fine.

@codeql-ci codeql-ci merged commit 9f2eb84 into github:main Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgerf asgerf asgerf approved these changes

Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erik-krogh @asgerf @codeql-ci