Skip to content

Replace getEncodedFile with shared getFileBySourceArchiveName predicate #4643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2020
Merged

Replace getEncodedFile with shared getFileBySourceArchiveName predicate #4643

merged 2 commits into from
Nov 10, 2020

Conversation

nickrolfe
Copy link
Contributor

While also making it work with paths for databases created on Windows.

@nickrolfe
Replace getEncodedFile with shared getFileBySourceArchiveName predicate
1e1eb7e 
While also making it work with paths for databases created on Windows.
@nickrolfe nickrolfe requested review from a team as code owners November 10, 2020 13:57
@nickrolfe nickrolfe mentioned this pull request Nov 10, 2020
Closed
aeisenberg
aeisenberg reviewed Nov 10, 2020
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this fixes the AST Viewer and other contextual queries on a previously broken database. Also, the code itself looks fine. I won't approve since I think someone from one of the analysis teams should look at too.

jbj
jbj approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@jbj jbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Languages LGTM. I'm not sure everyone wants IDEContextual.qll in their query root, but it should be easy enough to move for individual languages after this is merged.

@jbj jbj merged commit fc764db into github:main Nov 10, 2020
@nickrolfe nickrolfe deleted the getFileBySourceArchiveName branch November 10, 2020 16:38
@nickrolfe nickrolfe mentioned this pull request Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg left review comments

@jbj jbj jbj approved these changes

Assignees
No one assigned
Labels
C# C++ Java JS Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickrolfe @jbj @aeisenberg