Skip to content

C#: Refactor pattern extraction #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2020
Merged

C#: Refactor pattern extraction #4663

merged 2 commits into from
Nov 18, 2020

Conversation

tamasvajk
Copy link
Contributor

@tamasvajk tamasvajk commented Nov 12, 2020 •
edited
Loading

  • separated the classes into dedicated files
  • moved all pattern classes to a dedicated folder
  • deleted duplicated pattern extraction logic (IsPattern vs CasePattern).

@github-actions github-actions bot added the C# label Nov 12, 2020
@tamasvajk tamasvajk marked this pull request as ready for review November 12, 2020 14:52
@tamasvajk tamasvajk requested a review from a team as a code owner November 12, 2020 14:52
hvitved
hvitved approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks!

@tamasvajk
Copy link
Contributor Author

tamasvajk commented Nov 17, 2020 •
edited
Loading

I just started a differences job. Let's wait for it to finish before I merge this.

@tamasvajk tamasvajk merged commit cb8c5e8 into github:main Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamasvajk @hvitved