Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance numbers:
Using 16 threads for evaluator, with empty cache
boost, lockpool.cpp
before: total 85s, qlClass 10s, EB 30s
after: total 75s, qlClass 3s
openjdk, ad_x86.cpp
before: total 93s, qlClass 11s, EB 28
after: total 81s, qlClass 7.9s
The times for the individual predicates are from the query log, the total time is the wall time from the parallel execution.
EB is the predicate in
ElementBase
that computes theel
that need the default implementation ofgetAPrimaryQlClass
, i.e. where the predicate is not overriden.Note: Changing this default from "???" to no result is a breaking API change.
Part of https://github.com/github/codeql-c-analysis-team/issues/129