Remove unit tests for duplicate-code detection #4689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old Semmle duplicate-code detection code has never been done when extracting databases for the CodeQL CLI, except that `codeql test run` will run it _just_ in order to support tests of the feature. With the sunsetting of Odasa there's no need to even _test_ the feature anymore. This commit removes those tests that fail when the duplicate-code detector is turned off. Once it is merged and bumped, we can finally remove it from `codeql`.
hvitved
approved these changes
Nov 18, 2020
RasmusWL
approved these changes
Nov 19, 2020
hmakholm
added a commit
that referenced
this pull request
Nov 20, 2020
In #4689 I forgot to remove the `.expected` files too, but they are now of course useless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old Semmle duplicate-code detection code has never been done when extracting databases for the CodeQL CLI, except that
codeql test runwill run it just in order to support tests of the feature. With the sunsetting of Odasa there's no need to even test the feature anymore.This PR removes those tests that fail when the duplicate-code detector is turned off. Once it is merged and bumped, we can finally remove it from
codeql.(The underlying queries are still present; I'll leave their deletion to the language teams).