Python: Dataflow, variable capture #4710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both via nonlocal and via dict
RasmusWL
requested changes
Nov 24, 2020
There was a problem hiding this comment.
Overall LGTM, nice to have test of this 👍
I would really like a comment (in the code) explaining why it is important to have BOTH Out and Through functions. From your explanation that variable-capture might end up depending on the call-graph, it makes sense to test both scenarios, but when I forget about this in 6 months time, I will certainly be confused about this subtle nuance.
Nitpick: what is up with calling the functions Out and not out? 😄
python/ql/test/experimental/dataflow/variable-capture/nonlocal.py
Outdated
Show resolved
Hide resolved
python/ql/test/experimental/dataflow/variable-capture/nonlocal.py
Outdated
Show resolved
Hide resolved
python/ql/test/experimental/dataflow/variable-capture/nonlocal.py
Outdated
Show resolved
Hide resolved
python/ql/test/experimental/dataflow/variable-capture/nonlocal.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
RasmusWL
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests showing that we do not handle variable capture (ported from C#, adapted slightly).