Skip to content

Conversation

jf205
Copy link
Contributor

@jf205 jf205 commented Nov 23, 2020

@jf205 jf205 changed the title [Docs] Tidy up migrated migrated documentation [Docs] Combine non-migrated content into single project Nov 23, 2020
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes all make sense. The only thing that I wanted to highlight was that this doesn't entirely fix https://github.com/github/semmle-docs/issues/277.

If we're going to close that issue with this PR, then we need to put the information from two comments somewhere we'll remember them:

The first is obviously important and perhaps needs to go into the launch issue, or as a nested task on that issue? The second seems like a very good idea but could be a follow up issue.

@jf205
Copy link
Contributor Author

jf205 commented Nov 24, 2020

The changes all make sense. The only thing that I wanted to highlight was that this doesn't entirely fix github/semmle-docs#277.

If we're going to close that issue with this PR, then we need to put the information from two comments somewhere we'll remember them:

The first is obviously important and perhaps needs to go into the launch issue, or as a nested task on that issue? The second seems like a very good idea but could be a follow up issue.

Thanks @felicitymay. You're quite right about the redirects and banners. I've created issues for those tasks 👍🏻

@jf205 jf205 merged commit b5626cb into rc/1.26 Nov 24, 2020
@jf205 jf205 deleted the sd-277 branch November 24, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants