Skip to content

Python: better models of open function #4720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 27, 2020

Conversation

RasmusWL
Copy link
Member

Small improvements to open modeling, that I spotted while preparing to work in something else.

Would recommend reviewing commit-by-commit.

@RasmusWL RasmusWL requested a review from a team as a code owner November 24, 2020 17:33
@RasmusWL RasmusWL requested a review from yoff November 24, 2020 17:33
yoff
yoff previously approved these changes Nov 25, 2020
Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer, thanks. We might consider moving the definition of OpenCall below the definition of io_attr, but I am not even sure we do that in general. I guess what made me think this is really a desire to keep "providers" (like io_attr) and "users" (like `OpenCall) apart; that seems out of scope here..

@RasmusWL
Copy link
Member Author

Much nicer, thanks. We might consider moving the definition of OpenCall below the definition of io_attr, but I am not even sure we do that in general. I guess what made me think this is really a desire to keep "providers" (like io_attr) and "users" (like `OpenCall) apart; that seems out of scope here..

To be completely honest that did feel a bit dirty.

@RasmusWL RasmusWL marked this pull request as draft November 25, 2020 10:07
@RasmusWL
Copy link
Member Author

Converted to draft, since I'll try to write a new-style changenote for this

@RasmusWL RasmusWL marked this pull request as ready for review November 25, 2020 10:40
@RasmusWL RasmusWL requested a review from yoff November 25, 2020 10:40
Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoff yoff merged commit 346a007 into github:main Nov 27, 2020
@RasmusWL RasmusWL deleted the python-better-open-models branch November 27, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants