C++: Use model interfaces in DefaultSafeExternalAPIFunction #4729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ee previosuly-used implementation models private.
MathiasVP
force-pushed
the
safe-external-api-function-use-model-interfaces-only
branch
from
f165f49 to
7730f5d
Compare
geoffw0
reviewed
Nov 25, 2020
…ultSafeExternalAPIFunction.
jbj
approved these changes
Nov 26, 2020
geoffw0
approved these changes
Nov 26, 2020
There was a problem hiding this comment.
LGTM.
We've discussed of whether "write side effects" includes writes to sockets, files, or memory not seen by the caller.
I think that means we may want to refine the models in future. We also already have some special cases in Function.mayHaveSideEffects() that seem very similar to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/github/codeql-c-analysis-team/issues/189.
It turns out that the set of functions which are
ArrayFunctions with no output parameters is a strict superset of functions satisfying eitherPureStrFunction,StrLenFunctionorPureMemFunction. And when you factor out the functions that satisfy eitherTaintFunctionorDataFlowFunction(like we do inExternalAPIDataNode), I think these two sets are equivalent.