Skip to content

Python: Add modeling of django class based view handlers #4779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 18, 2020
Merged

Python: Add modeling of django class based view handlers #4779

merged 6 commits into from
Dec 18, 2020

Conversation

RasmusWL
Copy link
Member

@RasmusWL RasmusWL commented Dec 4, 2020

Two important things:

  1. As far as I'm aware, we don't have a good way of determining MRO without points-to. As far as I know, this PR is the first instance where we need it. See c7ab78f
  2. How do you feel about adding httpVerb and httpVerbLower to the HTTP concept? -- see 608ce50

@RasmusWL
Python: Simplify getARouteHandler for Django
ffdbecf
@RasmusWL
Python: Add class based route handler in django tests
4ead118 
Disabled CSRF middleware for now, since it blocked my debugging curl POST requests :(
@RasmusWL
Python: Add modeling of django class based view handlers
c7ab78f 
BUT, since MyCustomViewBaseClass.post (django-v2-v3/testapp/views.py) and
Foo.post (django-v2-v3/routing_test.py) aren't handled, this raises important
question about how to do MRO without points-to :S
@RasmusWL
Python: Expose HTTP verbs in HTTP concept
608ce50 
Let's discuss whether doing it this way is reasonable, since I'm not 100% sure
whether this fits into "concepts" or not.
@RasmusWL RasmusWL requested a review from a team as a code owner December 4, 2020 13:11
@RasmusWL RasmusWL mentioned this pull request Dec 16, 2020
Closed
yoff
yoff requested changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good, I also like the simplification in the first commit. I think Http verbs are a concept, just one that is fairly easy to recognize.

RasmusWL and others added 2 commits December 18, 2020 14:52
@RasmusWL RasmusWL requested a review from yoff December 18, 2020 14:12
yoff
yoff approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoff yoff merged commit a08eb99 into github:main Dec 18, 2020
@RasmusWL RasmusWL deleted the django-class-based-handlers branch December 18, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoff yoff yoff approved these changes

Assignees
No one assigned
Labels
documentation Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RasmusWL @yoff