Skip to content

Java: Add missing broken crypto algorithms #4833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2020
Merged

Java: Add missing broken crypto algorithms #4833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7facb4
Add missing broken crypto algorithms
luchua-bc Dec 16, 2020
6b77922
Fix typo and update qldoc
luchua-bc Dec 16, 2020
bed8a68
Exclude broken algorithms from the list of secure algorithms
luchua-bc Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/ql/src/Security/CWE/CWE-327/BrokenCryptoAlgorithm.qhelp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ data.</p>
</overview>
<recommendation>

<p>Ensure that you use a strong, modern cryptographic algorithm. Use at least AES-128 or RSA-2048.</p>
<p>Ensure that you use a strong, modern cryptographic algorithm. Use at least AES-128 or RSA-2048. Do not use the ECB encryption mode since it is vulnerable to replay and other attacks.</p>

</recommendation>
<example>
Expand Down
6 changes: 4 additions & 2 deletions java/ql/src/semmle/code/java/security/Encryption.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,9 @@ string getAnInsecureAlgorithmName() {
result = "RC2" or
result = "RC4" or
result = "RC5" or
result = "ARCFOUR" // a variant of RC4
result = "ARCFOUR" or // a variant of RC4
result = "ECB" or // encryption mode ECB like AES/ECB/NoPadding is vulnerable to replay and other attacks
result = "AES/CBC/PKCS[5|7]Padding" // CBC mode of operation with PKCS#5 (or PKCS#7) padding is vulnerable to padding oracle attacks
}

/**
Expand Down Expand Up @@ -139,7 +141,7 @@ string getASecureAlgorithmName() {
result = "SHA512" or
result = "CCM" or
result = "GCM" or
result = "AES" or
result = "AES([^a-zA-Z](?!ECB|CBC/PKCS[5|7]Padding)).*" or
result = "Blowfish" or
result = "ECIES"
}
Expand Down
4 changes: 3 additions & 1 deletion java/ql/test/library-tests/Encryption/Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ class Test {
"des",
"des_function",
"function_using_des",
"EncryptWithDES");
"EncryptWithDES",
"AES/ECB/NoPadding",
"AES/CBC/PKCS5Padding");

List<String> goodStrings = Arrays.asList(
"AES",
Expand Down
4 changes: 2 additions & 2 deletions java/ql/test/library-tests/Encryption/cryptoalgospec.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
| Test.java:35:4:35:17 | super(...) | Test.java:35:10:35:15 | "some" |
| Test.java:39:3:39:38 | getInstance(...) | Test.java:39:29:39:37 | "another" |
| Test.java:37:4:37:17 | super(...) | Test.java:37:10:37:15 | "some" |
| Test.java:41:3:41:38 | getInstance(...) | Test.java:41:29:41:37 | "another" |
2 changes: 2 additions & 0 deletions java/ql/test/library-tests/Encryption/insecure.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@
| Test.java:11:4:11:17 | "des_function" |
| Test.java:12:4:12:23 | "function_using_des" |
| Test.java:13:4:13:19 | "EncryptWithDES" |
| Test.java:14:4:14:22 | "AES/ECB/NoPadding" |
| Test.java:15:4:15:25 | "AES/CBC/PKCS5Padding" |
4 changes: 2 additions & 2 deletions java/ql/test/library-tests/Encryption/secure.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
| Test.java:16:4:16:8 | "AES" |
| Test.java:17:4:17:17 | "AES_function" |
| Test.java:18:4:18:8 | "AES" |
| Test.java:19:4:19:17 | "AES_function" |