Python: Add Tornado source modeling #4869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoff
reviewed
Jan 6, 2021
Comment on lines
477
to
480
| TornadoRouteRegex() { | ||
| this instanceof StrConst and | ||
| DataFlow::localFlow(DataFlow::exprNode(this), setup.getUrlPatternArg()) | ||
| } |
There was a problem hiding this comment.
We might be able to ask for a LocalSourceNode here.
There was a problem hiding this comment.
Yep, just rewrote it to match DjangoRouteRegex
|
Preliminary review, since it is only a draft. But it basically looks great 👍 (nice, clean history too) |
Now you can run them, and the examples have been adjusted so they actually work!
I should probably have split this up into 2 commits, so sorry that didn't happen :|
The reason this becomes valueable right now, is that we can mark routed params as taint-sources. Longer down the line, we can (hopefully) detect that a routed param will only accept digits, and mark it safe for some of our taint-tracking queries.
RasmusWL
force-pushed
the
tornado-source-modeling
branch
from
c8ddc8f to
f9a29cb
Compare
|
Basically nothing changed since your last "preliminary" review, now it's just rebased on top of main (meaning the UI is only listing the commits that are part of this PR). Only new thing is using LocalSourceNode as you suggested 😉 |
yoff
approved these changes
Jan 14, 2021
Good point. We probably should be tracking all those missing models in some issue 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft PR since it builds upon the changes from #4864.
Locally confirmed to bring back the missing result for https://lgtm.com/projects/g/ArchiveTeam/wpull?mode=tree.