Skip to content

C#: Remove throw completion from StringLiteral #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2021
Merged

C#: Remove throw completion from StringLiteral #4924

merged 1 commit into from
Jan 14, 2021

Conversation

tamasvajk
Copy link
Contributor

@tamasvajk tamasvajk commented Jan 7, 2021 •
edited
Loading

@github-actions github-actions bot added the C# label Jan 7, 2021
@tamasvajk tamasvajk force-pushed the feature/remove-string-literal-might-throw branch from 33fdce4 to 469e2f6 Compare January 7, 2021 12:47
@tamasvajk tamasvajk force-pushed the feature/remove-string-literal-might-throw branch from 469e2f6 to 056dbe3 Compare January 8, 2021 07:14
@tamasvajk tamasvajk marked this pull request as ready for review January 8, 2021 08:55
@tamasvajk tamasvajk requested a review from a team as a code owner January 8, 2021 08:55
hvitved
hvitved approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for the differences job.

@tamasvajk
Copy link
Contributor Author

There are no new/fixed findings in the differences job.

@tamasvajk tamasvajk merged commit b6107d3 into github:main Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamasvajk @hvitved