Skip to content

C#: Add output assembly to compilation #4927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 14, 2021
Merged

C#: Add output assembly to compilation #4927

merged 7 commits into from
Jan 14, 2021

Conversation

tamasvajk
Copy link
Contributor

@tamasvajk tamasvajk commented Jan 8, 2021 •
edited
Loading

This PR stores the output assembly in the compilation.

@github-actions github-actions bot added the C# label Jan 8, 2021
yo-h
yo-h reviewed Jan 12, 2021
View reviewed changes
@tamasvajk tamasvajk force-pushed the feature/comp-assembly branch from b17419f to fb13126 Compare January 13, 2021 08:26
@tamasvajk tamasvajk marked this pull request as ready for review January 13, 2021 15:55
@tamasvajk tamasvajk requested a review from a team as a code owner January 13, 2021 15:55
hvitved
hvitved requested changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one trivial comment.

@tamasvajk tamasvajk merged commit 842ed62 into github:main Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yo-h yo-h yo-h left review comments

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tamasvajk @hvitved @yo-h