Skip to content

Conversation

madneal
Copy link
Contributor

@madneal madneal commented Jan 9, 2021

No description provided.

Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @madneal! You're right about the additional error message.

The "expression" error also appears for the second example below—would you mind updating that section too? As in:

/*
  Compilation errors:
  ERROR: "str" is not bound to a value.
  ERROR: expression is not bound to a value.
*/
predicate shortString(string str) {
  str.length() < 10
}

@madneal
Copy link
Contributor Author

madneal commented Jan 11, 2021

@shati-patel Sorry for the miss, added

@smowton
Copy link
Contributor

smowton commented Jan 11, 2021

Without the specific applicable range seen in the UI, "expression is not bound to a value" isn't very meaningful -- suggest adding (referring to the expression i * 4) or similar in each instance.

Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the specific applicable range seen in the UI, "expression is not bound to a value" isn't very meaningful -- suggest adding (referring to the expression i * 4) or similar in each instance.

Fair point, @smowton. I've suggested another small tweak to clarify! After that, this should be ready to merge. Thank you for the help, @madneal

Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the edits! I'll get this merged once the tests are green 😃

@codeql-ci codeql-ci merged commit 4bc287e into github:main Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants