C++: Test of taint through ConstructorDelegationInit. #4941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdmarsh2
reviewed
Jan 11, 2021
cpp/ql/test/library-tests/dataflow/taint-tests/constructor_delegation.cpp
Outdated
Show resolved
Hide resolved
MathiasVP
previously approved these changes
Jan 11, 2021
MathiasVP
dismissed
their stale review
I didn't see Robert was already on it!
jbj
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add taint tests for
ConstructorDelegationInit, which appears to be working well for IR taint but not so well in AST taint. This test related to an old issue (https://github.com/github/semmle-jira-migration/issues/401) that I think we can close.