Skip to content

C#: Fix type mention extraction of named types with nullability enabled #4952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 14, 2021
Merged

C#: Fix type mention extraction of named types with nullability enabled #4952

merged 3 commits into from
Jan 14, 2021

Conversation

tamasvajk
Copy link
Contributor

@tamasvajk tamasvajk commented Jan 13, 2021 •
edited
Loading

@github-actions github-actions bot added the C# label Jan 13, 2021
@tamasvajk tamasvajk force-pushed the feature/type-mention-nullable branch from 152524d to c0e0bd2 Compare January 13, 2021 11:58
@tamasvajk tamasvajk force-pushed the feature/type-mention-nullable branch from 267b4b3 to 61b207f Compare January 13, 2021 13:49
@tamasvajk
Copy link
Contributor Author

I referenced an old commit SHA (9daeffb06f) in the differences job, which made the make_metrics_dataset.py fail. 9daeffb06f has the same parent as the current first commit in this PR (c2a4235db8), and both of them only adds tests, so the diff results are still valid.

@tamasvajk tamasvajk marked this pull request as ready for review January 14, 2021 08:16
@tamasvajk tamasvajk requested a review from a team as a code owner January 14, 2021 08:16
hvitved
hvitved approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamasvajk tamasvajk merged commit 36a1293 into github:main Jan 14, 2021
This was referenced Jan 14, 2021
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamasvajk @hvitved