C++: Exclude custom vprintf implementations from primitiveVariadicFormatter. #5059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my long awaited solution to the problems we've been seeing with
cpp/wrong-type-format-argument
producing false positives in the presence of certainprintf
implementations (see https://lgtm.com/projects/g/microsoft/ChakraCore/alerts/?mode=tree&ruleFocus=2160310550).As it happens this change removes ALL results on ChakraCore for
cpp/wrong-type-format-argument
(and alsocpp/non-portable-printf
, which is not on LGTM anyway). I believe that is what we want. Results are preserved on the other projects I tried (BOINC_boinc
andgodotengine_godot
) so I believe the change is functioning as intended.I went with
exists(f.getBlock())
rather thanexists(f.getFile().getRelativePath())
because, in my tests, the former would exclude things I don't think we really need it to (where the header has been copied into the source directory but the corresponding source has not?).