Skip to content

Conversation

alexet
Copy link
Contributor

@alexet alexet commented Feb 8, 2021

This is a degenerate form that is accepted in the compiler even if they don't make much sense. This now matches the actual implementation of this rule.

I'm not sure how much we want to adjust the text for this. Mostly it would be to emphasise that the lists could be empty. However the text for things like predicate declarations just implicitly accepts empty lists.

Fixes #5060

This is a degenerate form that is accepted in the compiler even if they don't make much sense. 

Fixes #5060
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I don't think we need to update the surrounding text: it's technically accurate as-is, and this looks like a fairly niche area of confusion 😄

Feel free to merge whenever!

@alexet alexet merged commit bed10ad into main Feb 9, 2021
@alexet alexet deleted the alexet/fix-var-decls-spec branch February 9, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear QL Language specification for forex(| formula)
2 participants