Python: Model get_redirect_url in django #5151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's really the django version I care about :P
RasmusWL
force-pushed
the
django-get-redirect-url
branch
from
a582d86 to
7451484
Compare
yoff
approved these changes
Feb 25, 2021
Comment on lines
+2165
to
+2167
| * Note: this function only does something on a subclass of `RedirectView`, but since | ||
| * classes can be considered django view classes without us knowing their super-classes, | ||
| * we need to consider _any_ django view class. I don't expect any problems to come from this. |
There was a problem hiding this comment.
Thanks, I was wondering about this 👍
| routeHandler.getArg(routeHandler.getRequestParamIndex() + regex.getGroupNumber(_, _)) | ||
| routeHandler | ||
| .getArg(routeHandler.getFirstPossibleRoutedParamIndex() - 1 + | ||
| regex.getGroupNumber(_, _)) | ||
| or |
There was a problem hiding this comment.
I might have written the -1 at the end because I think of it as shifting group numbers from 1-based to 0-based.
There was a problem hiding this comment.
that would probably have made more sense 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR since it depends on the changes from #5139 (now merged)