Java: Add models for Commons ToStringBuilder #5181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
force-pushed
the
smowton/feature/commons-tostringbuilder
branch
from
8baae0f to
82dad2d
Compare
|
@aschackmull this has been rewritten using the new fluent-method support and CSV specifications. |
smowton
force-pushed
the
smowton/feature/commons-tostringbuilder
branch
from
b009a10 to
f01c027
Compare
aschackmull
reviewed
Apr 21, 2021
| row = | ||
| [ | ||
| "org.apache.commons.lang3.builder;ToStringBuilder;false;toString;;;Argument[-1];ReturnValue;taint", | ||
| "org.apache.commons.lang3.builder;ToStringBuilder;false;append;(java.lang.Object);;Argument;ReturnValue;taint", |
There was a problem hiding this comment.
Argument without indices are no longer supported for flow-through.
aschackmull
reviewed
Apr 21, 2021
| "org.apache.commons.lang3.builder;ToStringBuilder;false;toString;;;Argument[-1];ReturnValue;taint", | ||
| "org.apache.commons.lang3.builder;ToStringBuilder;false;append;(java.lang.Object);;Argument;ReturnValue;taint", | ||
| "org.apache.commons.lang3.builder;ToStringBuilder;false;append;(java.lang.Object);;Argument;Argument[-1];taint", | ||
| "org.apache.commons.lang3.builder;ToStringBuilder;false;append;(java.lang.Object[]);;Argument;ReturnValue;taint", |
There was a problem hiding this comment.
Input should likely be ArrayElement of Argument[0] for the various array inputs.
aschackmull
reviewed
Apr 21, 2021
| "org.apache.commons.lang3.builder;ToStringBuilder;false;append;(java.lang.Object);;Argument;Argument[-1];taint", | ||
| "org.apache.commons.lang3.builder;ToStringBuilder;false;append;(java.lang.Object[]);;Argument;ReturnValue;taint", | ||
| "org.apache.commons.lang3.builder;ToStringBuilder;false;append;(java.lang.Object[]);;Argument;Argument[-1];taint", | ||
| "org.apache.commons.lang3.builder;ToStringBuilder;false;append;(java.lang.String,java.lang.Object[]);;Argument;ReturnValue;taint", |
There was a problem hiding this comment.
Lines like this should be superfluous now, right? With a fluent spec we just need to taint Argument[-1].
These don't include support for reflectionToString yet, which is coming up in a subsequent PR.
|
@aschackmull changes applied; tests expected to fail for the time being. |
It doesn't look like you pushed any changes. |
smowton
force-pushed
the
smowton/feature/commons-tostringbuilder
branch
from
f01c027 to
76091f0
Compare
|
Doh, force-pushed (rebase) |
|
Test failures expected for now (pending array Content implementation) |
aschackmull
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These don't include support for reflectionToString yet, which is coming up in a subsequent PR.