Skip to content

Conversation

RasmusWL
Copy link
Member

@RasmusWL RasmusWL requested a review from a team February 16, 2021 13:39
@RasmusWL RasmusWL requested a review from felicitymay February 16, 2021 13:40
@RasmusWL
Copy link
Member Author

@felicitymay I added you as a reviewer, just because I know absolutely nothing about how the docs site is updated, so https://codeql.github.com/docs/codeql-overview/supported-languages-and-frameworks/ gets the new info.

I don't think you need to do any review of the actual change, since it just updates the list of supported frameworks.

:header-rows: 1
:class: fullWidthTable
:widths: auto

Name, Category
Bottle, Web framework
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to e.g. Bottle?
It seems to still be supported? https://github.com/github/codeql/search?q=Bottle

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're in the process of moving our queries away from points-to, and use the same approach as the CodeQL libraries for JS does with type-tracking and API graphs. This means that we need to re-model libraries, and so far Bottle has not been prioritized.

@felicitymay
Copy link
Contributor

@felicitymay I added you as a reviewer, just because I know absolutely nothing about how the docs site is updated, so https://codeql.github.com/docs/codeql-overview/supported-languages-and-frameworks/ gets the new info.

Hi @RasmusWL - thanks for the ping. Can you confirm when/where this needs to be updated?

Context: we normally update the CodeQL microsite with every new release of the CodeQL CLI (next one due in a couple of weeks) and help.semmle.com with every release of LGTM Enterprise.

@RasmusWL
Copy link
Member Author

Hi @RasmusWL - thanks for the ping. Can you confirm when/where this needs to be updated?

Context: we normally update the CodeQL microsite with every new release of the CodeQL CLI (next one due in a couple of weeks) and help.semmle.com with every release of LGTM Enterprise.

Thanks. Updating the microsite is not critical, so I'm perfectly fine if this update first goes live in a couple of weeks 👍

@RasmusWL RasmusWL removed the request for review from felicitymay February 16, 2021 14:36
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@tausbn tausbn merged commit 593a96f into github:main Feb 17, 2021
@RasmusWL RasmusWL deleted the update-supported-python-frameworks-docs branch February 18, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants