Skip to content

JS: Add flow sources from vue-router #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2021
Merged

JS: Add flow sources from vue-router #5199

merged 4 commits into from
Feb 25, 2021

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Feb 17, 2021 •
edited
Loading

Evaluations: (internal links)

@asgerf asgerf added JS Awaiting evaluation Do not merge yet, this PR is waiting for an evaluation to finish labels Feb 17, 2021
@asgerf asgerf requested a review from a team as a code owner February 17, 2021 15:37
erik-krogh
erik-krogh previously approved these changes Feb 17, 2021
View reviewed changes
@asgerf
Copy link
Contributor Author

asgerf commented Feb 22, 2021 •
edited
Loading

Evaluation on default slugs showed a big outlier that needs investigation.

@asgerf
Copy link
Contributor Author

asgerf commented Feb 25, 2021 •
edited
Loading

The optimizer wobbles a bit when touching the Vue model, but after a lot of tweaking performance now seems tolerable:

@asgerf asgerf removed the Awaiting evaluation Do not merge yet, this PR is waiting for an evaluation to finish label Feb 25, 2021
@codeql-ci codeql-ci merged commit 1bd12e6 into github:main Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erik-krogh erik-krogh erik-krogh approved these changes

Assignees
No one assigned
Labels
documentation JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asgerf @erik-krogh @codeql-ci