JS: Improve performance in API-graphs. #5200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
added
the
Awaiting evaluation
erik-krogh
removed
the
Awaiting evaluation
max-schaefer
suggested changes
Feb 18, 2021
Co-authored-by: Max Schaefer <54907921+max-schaefer@users.noreply.github.com>
max-schaefer
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by a performance regression in
openlayers/ol2.Evaluation looks great. (I only evaluated on
TaintedPath.ql)./cc @tausbn, @max-schaefer (I added you guys to my evaluation-repo above).
TODO: I also did an evaluation on each commit on it's own. And I might revert theAPI::InvokeNode::getParameterchange.I can't see from an evaluation if the
API::InvokeNode::getParameterchange helps.But it saved 7.5s for
TaintedPath.qlonol2on my machine, so I'm keeping it.