Skip to content

Java: Add modelling for Apache HTTP Components #5202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 3, 2021
Merged

Java: Add modelling for Apache HTTP Components #5202

merged 15 commits into from
Mar 3, 2021

Conversation

joefarebrother
Copy link
Contributor

No description provided.

@joefarebrother joefarebrother requested a review from a team as a code owner February 17, 2021 18:02
aschackmull
aschackmull reviewed Feb 23, 2021
View reviewed changes
aschackmull
aschackmull reviewed Feb 23, 2021
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Do you prefer to merge this in its current form or do you want to use this as a testing ground for csv-based modelling? - it seems like most of this should convert fairly easily.

@joefarebrother
Copy link
Contributor Author

I think I'll try converting it to the CSV modelling system

@joefarebrother
Copy link
Contributor Author

@aschackmull I have converted it over.

@aschackmull aschackmull merged commit 3400c12 into github:main Mar 3, 2021
@joefarebrother joefarebrother deleted the apache-http branch March 3, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

Assignees
No one assigned
Labels
documentation Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joefarebrother @aschackmull