JS: Various small performance improvements

[erik-krogh]

Evaluation on default/TaintedPath.ql.

Makes various predicates run faster by changing the join order.
I found them by running TaintedPath.ql on vscode, and then looking through the clause timing reports and tuple counts.

It also makes the globalVarRef predicate non-recursive.
So we no longer treat e.g. window.globalThis.global.window as being a reference to the global object.
(The performance benefit of that change is minor, so let me know if you want it reverted).

Summary of how how time is saved by each commit (TaintedPath.ql running on VSCode).

• rearange ArrayIndexingStep to avoid #shared predicate - saves about 5s
• cache AstNode::getParent - saves a few seconds
• make globalVarRef non recursive - saves about 200ms
• remove magic from inGuard - saves about 1-2 seconds
• outline callee computation - to avoid many joins on getACall - saves about 300ms
• change join order for summarizedHigherOrderCall - saves about 11s
• change join order for SystemCommandExecutors - and use ApiGraphs::getACall - saves about 5s

[asgerf]

Nice!

Could you run evaluations of the whole security suite to make sure we aren't breaking performance somewhere else?

[erik-krogh]

Nice!

Could you run evaluations of the whole security suite to make sure we aren't breaking performance somewhere else?

Looks OK: https://github.com/dsp-testing/erik-krogh-BCQS/tree/auto/data/workflow/vsperf-nigtly-validation/reports