C#: Add tuple dataflow #5242
Merged
C#: Add tuple dataflow #5242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
force-pushed
the
feature/tuple-df
branch
from
8ad11c7 to
a17df10
Compare
tamasvajk
force-pushed
the
feature/tuple-df
branch
3 times, most recently
from
6aeca4e to
f1b5d83
Compare
tamasvajk
commented
Feb 24, 2021
tamasvajk
force-pushed
the
feature/tuple-df
branch
2 times, most recently
from
b1bd299 to
eb2e431
Compare
tamasvajk
force-pushed
the
feature/tuple-df
branch
from
1ed7bb5 to
d11ac7f
Compare
tamasvajk
force-pushed
the
feature/tuple-df
branch
from
ab5059b to
0defad7
Compare
|
@hvitved I rebased this PR to fix the merge conflicts, fixed the nullability annotations in new code, and added an extra commit to handle patterns. (Let's see which other tests need to be adjusted) Here's the new differences job. |
hvitved
reviewed
Mar 9, 2021
csharp/ql/src/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll
Outdated
Show resolved
Hide resolved
|
@hvitved I added an extra commit with mixed positional and variable decl. tuple pattern. I'm not going to address that in this PR, but it shows what I'd like to cover next. |
hvitved
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds better data flow support for tuples. We're now tracking data flowing into tuple fields and out of them. Also, tuple extraction was slightly changed to remove named tuple fields.
Differences jobDifferences jobDifferences job