Skip to content

Conversation

tausbn
Copy link
Contributor

@tausbn tausbn commented Feb 23, 2021

Straightforward. Since this should preserve behaviour, I don't think it needs a separate change note.

Still needs validation that no results were lost in this port.

@tausbn tausbn added Python no-change-note-required This PR does not need a change note labels Feb 23, 2021
@tausbn tausbn requested a review from a team as a code owner February 23, 2021 19:04
@yoff
Copy link
Contributor

yoff commented Feb 23, 2021

That is a good point, I initially thought that moving code away from the points-to api went into change notes, but, thinking about it, it is probably a bit too internal for such a user-facing channel.

@yoff
Copy link
Contributor

yoff commented Feb 23, 2021

Did you want tomato it a draft until results are validated, or does that validation come with the next list-upgrade?

@tausbn
Copy link
Contributor Author

tausbn commented Feb 23, 2021

Did you want 🍅 it a draft until results are validated, or does that validation come with the next list-upgrade?

I made it non-draft, since I think it can be reviewed in its current state. I could add the "Awaiting evaluation" label, but you make a good point about just doing it in the next dist-upgrade. This is not a terribly complicated query, and I don't expect much change in the results (if any). I would be fine with simply observing the changes in the next dist-upgrade.

Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I was about to do the same change, and also wanted to argue that we could just merge it without doing any validation of results up front. So I'm just going to go ahead and merge it 💪

@RasmusWL RasmusWL merged commit 358ade6 into github:main Feb 23, 2021
@tausbn tausbn deleted the python-port-insecure-temporary-file branch February 23, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants