Python: Ensure old dataflow queries are not used #5279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to have been some cases where the old ones have been picked up instead of the new ones. At least I spotted _one_ case where this happened, in an internal actions run. I'm not sure how to actual debug this, so just removing all the tags that could make these queries to become picked up :|
|
This turned out to just be someone listing the old queries by accident. I would still like this PR to get in though, so no-one in the future will find those old queries if they grep for a known query-id... We could probably also remove them soon-ish, but I didn't want to make that decision for this PR. |
tausbn
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to have been some cases where the old ones have been picked up instead of the new ones. At least I spotted one case where this happened, in an internal actions run.
I'm not sure how to actual debug this, so I'm just removing all the tags that could make these queries to become picked up :|