Skip to content

Java: Improve constant-loop-condition #5334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2021
Merged

Java: Improve constant-loop-condition #5334

merged 1 commit into from
Mar 5, 2021

Conversation

Marcono1234
Copy link
Contributor

Changes the query to allow FieldRead as long as the field is final.

@Marcono1234 Marcono1234 requested a review from a team as a code owner March 4, 2021 22:34
@github-actions github-actions bot added the Java label Mar 4, 2021
aschackmull
aschackmull approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aschackmull aschackmull added the no-change-note-required This PR does not need a change note label Mar 5, 2021
@aschackmull aschackmull merged commit 0d7f6ce into github:main Mar 5, 2021
@Marcono1234 Marcono1234 deleted the marcono1234/improve-constant-loop-condition branch March 5, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

Assignees
No one assigned
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marcono1234 @aschackmull