Java: Convert existing Commons Lang models to CSV #5372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
changed the title
aschackmull
reviewed
Mar 24, 2021
| override predicate row(string row) { | ||
| row = | ||
| [ | ||
| "org.apache.commons.lang3.text;StrBuilder;false;StrBuilder;(java.lang.String);;Argument;ReturnValue;taint", |
There was a problem hiding this comment.
Constructors should use Argument[-1] instead of ReturnValue to represent the constructed value. That way extending classes will also get proper flow through calls to super, which isn't an expression and therefore doesn't work with ReturnValue. The fact that ReturnValue currently mostly works is essentially a bug that will be fixed soon.
|
The adjustment for constructors should be an easy fix, so I think we should at least include that. Switching from |
All instances are replaced with a specific Argument or range.
|
@aschackmull both conversions applied (and rebased on latest |
smowton
force-pushed
the
smowton/feature/commons-lang-models-to-csv
branch
from
4640935 to
eaa2d4d
Compare
aschackmull
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds tests for ArrayUtils and amends the existing models, which weren't quite right. Some void-returning methods were dropped, some additional parameters that can incorporate taint were added, and the stringifying methods were dropped on grounds that we don't usually consider toString taint-propagating AFAIK (though particular queries may differ in this respect)