JS: Add model of d3 selections #5379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
added
JS
Awaiting evaluation
erik-krogh
reviewed
Mar 11, 2021
There was a problem hiding this comment.
Nice.
What is the status of recognizing the source of CVE-2017-1000006?
I guess we don't recognize it.
Comment on lines
8
to
12
| API::Node d3() { | ||
| result = API::moduleImport("d3") | ||
| or | ||
| result = API::moduleImport("d3-node").getInstance().getMember("d3") | ||
| } |
There was a problem hiding this comment.
I had expected that d3 would also be used as a global variable.
There was a problem hiding this comment.
Good point, we should totally recognize that.
javascript/ql/src/semmle/javascript/security/dataflow/XssThroughDomCustomizations.qll
Show resolved
Hide resolved
Oh thanks for brining that up. Added a few things that I missed from the model. We do find the sources now. |
|
New evaluations on d3 slugs and on default slugs look mostly OK, but I'll take a bit of time to investigate the slowest ones. |
asgerf
removed
the
Awaiting evaluation
|
As far as I can tell the outliers are just noise. |
erik-krogh
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a model of
d3selections, which is the only part ofd3where I could find anything relevant for our security queries.d3selections are a bit likejQueryobjects, in that they contain a collection of DOM elements, and have methods for interacting with them. The model just contributes news ways of interacting with the DOM viad3selections.Evaluations: (internal links)