Skip to content

Conversation

igfoo
Copy link
Contributor

@igfoo igfoo commented Mar 11, 2021

No description provided.

@igfoo igfoo added the C++ label Mar 11, 2021
@igfoo igfoo requested a review from criemen March 11, 2021 14:10
@igfoo igfoo requested a review from a team as a code owner March 11, 2021 14:10
Copy link
Collaborator

@criemen criemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick.
I'm happy to merge this now as a PoC, but I think we should take a look together at the requirements and what they mean for us in the wider context of the epic.

@@ -0,0 +1,22 @@
/**
* @kind diagnostic
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the spec (that was probably updated after you wrote the query), this is missing a name and description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta, added

Copy link
Collaborator

@criemen criemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@criemen criemen merged commit 0274162 into main Mar 12, 2021
@criemen criemen deleted the igfoo/failed_extractions branch March 12, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants