JS: recognize strings in callbacks in getAReplacementString #5400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
force-pushed
the
replaceCallbacks
branch
from
f70f694 to
3640bbd
Compare
asgerf
reviewed
Mar 17, 2021
| @@ -149,6 +149,19 @@ class StringReplaceCall extends DataFlow::MethodCallNode { | |||
| pr.flowsTo(replacer.getAReturn()) and | |||
| map.hasPropertyWrite(old, any(DataFlow::Node repl | repl.getStringValue() = new)) | |||
| ) | |||
| or | |||
| exists( | |||
There was a problem hiding this comment.
Could you add a comment with a quick example of the syntax we're trying to match here?
For example
// str.replace(regex, match => {
// if (match === 'old') return 'new';
// })
javascript/ql/src/semmle/javascript/security/IncompleteBlacklistSanitizer.qll
Outdated
Show resolved
Hide resolved
…stSanitizer.qll Co-authored-by: Asger F <asgerf@github.com>
asgerf
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets a TP/TN for CVE-2021-3377
I decided to use
StringReplaceCall::replaces/2insidegetAReplacementStringbecause it gives me a natural way of getting the TP for the CVE, and I couldn't come up with a good reason for why not to do it (no test-case broke, and evaluation is clean).Evaluation is good.
No change in performance or results.