Python: Small PyYAML improvements #5437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found this randomly
For now, this is how we're trying to structure things -- all in all it doesn't matter too much, since everything is still marked as private.
```
In [6]: yaml.load("!!python/object/new:os.system [echo EXPLOIT!]", yaml.CLoader)
EXPLOIT!
Out[6]: 0
```
Not really that important. But easy to do while I was working on this library.
yoff
requested changes
Mar 18, 2021
There was a problem hiding this comment.
This is great. Only request is that the (otherwise nice) added headings in the test file now suggest an organisation of calls into those which are safe and those which are unsafe. If we keep those headings, we should also follow this organisation in the rest of the file and fold in the load_all variants and the C-based loaders.
|
Done 👍 |
yoff
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.